std.format: clean imports #2666
Conversation
| } | ||
| version(unittest) { | ||
| import core.vararg; | ||
| import std.conv, std.exception, std.range, std.traits, std.typetuple; |
There was a problem hiding this comment.
Is it possible to also move std.conv into local imports? The fewer module-global imports, the better IMO, since it will make it much easier to split up Phobos modules into smaller, independent pieces.
|
btw, have you thought about writing an automated tool to make cleaning up imports easier? I have suggested the feature for dfix, maybe it's something you'd want to implement. It'd make cleaning up phobos much easier and be more widely useful for others too. |
|
Good idea! But phobos needs review. I have found 2 bugs. |
remove new private stuff add local import add local import remove global std.con import
|
rebased |
| nested = to!(typeof(nested))(trailing[i + 1 .. k - 1]); | ||
| sep = to!(typeof(nested))(trailing[k + 1 .. j - 1]); | ||
| nested = trailing[i + 1 .. k - 1]; | ||
| sep = trailing[k + 1 .. j - 1]; |
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
The reason is to don't import std.conv: this to! do nothing for const(Char)[].
There was a problem hiding this comment.
const(Char)[] a;
...
assert(to!(typeof(a))a is a);
|
LGTM |
|
Auto-merge toggled on |
|
Thanks! |
|
My bad. Please merge #2683. |
Issue 13253 - use more scoped imports in phobos
See also: #2661