New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.conv: clean imports & parse (null and bool) fix #2667
Conversation
Can we temporarily take out the changes to |
A am not alone :-) ///phobos / std / digest / digest.d
body
{
enum string msg = "Buffer needs to be at least " ~ digestLength!(T).stringof ~ " bytes " ~
"big, check " ~ typeof(this).stringof ~ ".length!";
asArray!(digestLength!T)(buf, msg) = _digest.finish();
return buf[0 .. digestLength!T];
} |
|
I'm pretty sure that code was from before |
fix parse for null and bool 1. Allow parse nulls from input range 2. Remove slow (unicode like) version of parse for bools. 3. Range version of parse for bools is used. revert some changes remove some changes remove few changes
@quickfur I gave up :-) |
// string to bool conversions | ||
Target parse(Target, Source)(ref Source s) | ||
if (isExactSomeString!Source && | ||
is(Unqual!Target == bool)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is slower then common function for input range of dchar. See line 1840.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
LGTM, thanks! |
Auto-merge toggled on |
std.conv: clean imports & parse (null and bool) fix
Hmm. Not sure if it's this PR, or something else, that just broke the druntime tests. :-( |
How can phobos PR possibly break druntime tests? |
You're right, what was I thinking. Nevermind what I said.
|
Issue 13253 - use more scoped imports in phobos
See also: #2661