std.utf: clean imports #2669
Merged
std.utf: clean imports #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import std.conv : to; | ||
| import std.exception; | ||
| import std. string : format; | ||
| import core.exception : AssertError; |
There was a problem hiding this comment.
This same block of imports seem repeated across many unittests; how about merging them into a single version(unittest) block?
There was a problem hiding this comment.
version(unittest) global import is huge headache while testing new scoped imports for the same modules.
There was a problem hiding this comment.
Good point. Maybe it's OK then.
There was a problem hiding this comment.
All PRs like this are first step. There will be second step after std.range package, and maybe third step, after 'std.algorithm' package.
|
Other than that, LGTM. |
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 13253 - use more scoped imports in phobos
See also: #2661