std.getopt: clean imports #2710
Conversation
| { | ||
| import std.stdio; // for testing only | ||
| } | ||
| import std.traits; |
There was a problem hiding this comment.
👍 Nice, reduce everything to a single global import. :-)
|
LGTM |
|
Auto-merge toggled on |
| @@ -892,7 +904,7 @@ private bool optMatch(string arg, string optPattern, ref string value, | |||
| //writeln("isLong: ", isLong); | |||
| // yank the second '-' if present | |||
| if (isLong) arg = arg[1 .. $]; | |||
| immutable eqPos = std.string.indexOf(arg, assignChar); | |||
|
Fails the tester |
|
Probably unrelated but needs checking |
|
@Dicebot Probably unrelated, since the same platform later on became green again on the same commit. |
|
FreeBSD 32-bit seems to be a somewhat frequent offender in auto-tester :( |
|
This wouldn't be the first time... I remember @MartinNowak was going to look into possible race conditions that intermittently cause the thread unittests to fail, but I don't know if that was ever found. Instead, there's just a timer that expires if the test takes too long to run, and on some platforms the timer is too short and occasionally expires even when the test is actually OK, probably due to heavy system load. |
|
@Dicebot All of FreeBSD seems to be. And I think it's some FreeBSD 8.x ... just scary. |
|
If it's 8.4, it's not too bad, as support isn't expiring until next year... But 8.1 would be pretty scary, since support has already expired in 2012. |
|
The thread priority issue was fixed with dlang/druntime#550. |
|
Weird, recently I still see thread-related failures every now and then. Not sure if it's the same issue, or more likely, something else that's also thread-related. |
|
+1 |
Please file issues in bugzilla for failing test cases. |
No description provided.