New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement byPair. #2842
Implement byPair. #2842
Conversation
@@ -316,6 +316,66 @@ unittest | |||
static assert(!__traits(compiles, assocArray(b))); | |||
} | |||
|
|||
/** | |||
Iterate over an associative array by key/value tuples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this doesn't iterate, it just returns a range that can be lazily iterated over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Done |
@@ -316,6 +316,66 @@ unittest | |||
static assert(!__traits(compiles, assocArray(b))); | |||
} | |||
|
|||
/** | |||
Construct a range iterating over an associative array by key/value tuples. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need Params:
section.
Improve docs a little.
Hide ugly-as-sin internal comment about compiler bug that shouldn't be in the generated documentation!
14d7470
to
5d440aa
Compare
Done |
@@ -263,8 +263,9 @@ unittest | |||
} | |||
|
|||
/** | |||
Returns a newly allocated associative array out of elements of the input range, | |||
which must be a range of tuples (Key, Value). | |||
Params: r = An input range of tuples of keys and values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: Will the docs be generated properly without a blank line between Params
and Returns
(and Returns
and See Also
) sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Wed, Jan 07, 2015 at 09:49:09AM -0800, Andrej Mitrović wrote:
Quick question: Will the docs be generated properly with a lack of a blank line between
Params
andReturns
(andReturns and
See Also`) sections?
Yep, see the preview here: http://eusebeia.dyndns.org/~hsteoh/tmp/web/phobos-prerelease/std_array#.assocArray
This LGTM. Ready for merging? |
I'm ready to merge, dunno about the reviewers. :-P |
Well the big work was already done in the druntime pull, I don't see anything blocking this. |
Auto-merge toggled on |
Thanks! |
Depends on: dlang/druntime#1070