Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement byPair. #2842

Merged
3 commits merged into from Jan 8, 2015
Merged

Implement byPair. #2842

3 commits merged into from Jan 8, 2015

Conversation

quickfur
Copy link
Member

@quickfur quickfur commented Jan 4, 2015

Depends on: dlang/druntime#1070

@@ -316,6 +316,66 @@ unittest
static assert(!__traits(compiles, assocArray(b)));
}

/**
Iterate over an associative array by key/value tuples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this doesn't iterate, it just returns a range that can be lazily iterated over.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@quickfur
Copy link
Member Author

quickfur commented Jan 4, 2015

Done

@@ -316,6 +316,66 @@ unittest
static assert(!__traits(compiles, assocArray(b)));
}

/**
Construct a range iterating over an associative array by key/value tuples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need Params: section.

H. S. Teoh added 3 commits January 7, 2015 06:32
Improve docs a little.
Hide ugly-as-sin internal comment about compiler bug that shouldn't be
in the generated documentation!
@quickfur
Copy link
Member Author

quickfur commented Jan 7, 2015

Done

@@ -263,8 +263,9 @@ unittest
}

/**
Returns a newly allocated associative array out of elements of the input range,
which must be a range of tuples (Key, Value).
Params: r = An input range of tuples of keys and values.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: Will the docs be generated properly without a blank line between Params and Returns (and Returns and See Also) sections?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Wed, Jan 07, 2015 at 09:49:09AM -0800, Andrej Mitrović wrote:

Quick question: Will the docs be generated properly with a lack of a blank line between Params and Returns (and Returns andSee Also`) sections?

Yep, see the preview here: http://eusebeia.dyndns.org/~hsteoh/tmp/web/phobos-prerelease/std_array#.assocArray

@ghost
Copy link

ghost commented Jan 7, 2015

This LGTM. Ready for merging?

@quickfur
Copy link
Member Author

quickfur commented Jan 7, 2015

I'm ready to merge, dunno about the reviewers. :-P

@ghost
Copy link

ghost commented Jan 8, 2015

Well the big work was already done in the druntime pull, I don't see anything blocking this.

@ghost
Copy link

ghost commented Jan 8, 2015

Auto-merge toggled on

@quickfur
Copy link
Member Author

quickfur commented Jan 8, 2015

Thanks!

ghost pushed a commit that referenced this pull request Jan 8, 2015
@ghost ghost merged commit 88722a8 into dlang:master Jan 8, 2015
@quickfur quickfur deleted the issue9119_byPair branch January 8, 2015 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants