Fix Issue #14058 -- 'make install' should not copy non-source files #2918
Conversation
This patch ensures that 'make install' will copy only actual phobos files to the install src/ dir and not (for example) backup files left behind by code editors.
|
Dammit, I was worried about that |
|
According to the manpage, you should use |
| cp -r std/* $(INSTALL_DIR)/src/phobos/std/ | ||
| cp -r etc/* $(INSTALL_DIR)/src/phobos/etc/ | ||
| mkdir -p $(INSTALL_DIR)/src/phobos | ||
| find std -type f -name "*.d" | xargs -n1 -i cp -r --parents {} $(INSTALL_DIR)/src/phobos/ |
There was a problem hiding this comment.
This will break when we add some .di files to Phobos.
There was a problem hiding this comment.
Yes, I know. The original version did have an -o -name "*.di" extra in there, but I removed it when I realized there weren't actually any .di files at present. Anyway, in light of your other comment, this should be rethought anyway ;-)
|
Using wildcards in makefiles is a bit of an antipattern. We have a list of all Phbos source modules. We should use that. |
Yup. I didn't manage to get that working this morning (I was in a rush and so switched to |
|
@WebDrake thx, looking forward to the new coolness |
|
ping |
|
@WebDrake ? Going to put this to rest in a couple of weeks. |
|
I'm sorry to say that it's unlikely I'll follow up in the next 2 weeks. I can always reawaken this once I have time, so if it simplifies matters for you, please do feel free to close it sooner or later. |
|
@WebDrake we have bugzilla and I generally try to leave links to prior work when closing stuff. And yes one less pull with limbo status is always simpler to manage. |
This patch ensures that
make installwill copy only actual phobos files to the installsrc/dir and not (for example) backup files left behind by code editors.