New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets for Win32/COFF to win64.mak #3150
Conversation
The build fails because the tester tries to patch the makefile instead of passing changed variables as command line arguments. |
@@ -481,6 +481,17 @@ cov : $(SRC_TO_COMPILE) $(LIB) | |||
|
|||
html : $(DOCS) | |||
|
|||
################### Win32 COFF support ######################### | |||
|
|||
# default to 32-bit compiler relative to 64-bit compiler, link and lib are architecture agnostic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what "32-bit compiler relative to 64-bit compiler" means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VC 32-bit compiler is in the parent folder of the folder that contains the 64-bit compiler, e.g. for the default CC="$(VCDIR)\bin\amd64\cl", the 32-bit compiler is CC32="$(VCDIR)\bin\cl". Maybe there is a better wording...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"relative to the location of the 64 bit compiler"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"relative to the location of the 64 bit compiler"
Ah, ok. That's where the confusion comes from. I've updated the comment.
Auto-merge toggled on |
Add targets for Win32/COFF to win64.mak
Add targets for Win32/COFF to win64.mak
This adds targets
phobos32mscoff
andunittest32mscoff
to win64.mak.The 32-bit compiler is derived from the setting for the 64-bit compiler, but can be overwritten on the make command line with
CC32=
The usual conditions for
VCDIR
andSDKDIR
apply,though the default is improved by using. As for Win64 since the$(ProgramFiles)
-conf=
setting, it is necessary to setLINKCMD
andLIB
in the environment to link the unittests.