package-shared unittest functions should not be under version(unittest) #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally there's a speedup too: takes 48 seconds on my laptop, whereas takes 45. |
…o added mktemp to run each unittest in its own dir
|
Also tried on a big iron at work with -j64, 24s with the old unittest target, 20s with the new one (debug mode). |
|
LGTM |
|
Auto-merge toggled on |
burner
added a commit
that referenced
this pull request
Jun 12, 2015
package-shared unittest functions should not be under version(unittest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package-shared artifacts used only for unittesting should not be versioned with
version(unittest)because that precludes unittesting one or more modules against the build library. Example:has link-time errors. This PR fixes them.