Supplemental fix for issue 14846 #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`new Input!(Range, ErrorLevel)` should take the `input` parameter to initialize its field by that, because: if `Range` is a nested struct, its context pointer is not accessible from inside CsvReader.
|
LGTM - maybe add a comment to the source? |
|
Thanks @DmitryOlshansky. Normally Phobos code don't have to have comments for the already-fixed compiler bugs. After the compiler fix, such the incorrect code will be merely disallowed. I think the detailed commit message is enough. |
|
Auto-merge toggled on |
9rnsr
added a commit
that referenced
this pull request
Jul 29, 2015
Supplemental fix for issue 14846
Oh, great. Then it's all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14846
new Input!(Range, ErrorLevel)should take theinputparameter to initialize its field by that, because: ifRangeis a nested struct, its context pointer is not accessible from inside CsvReader.Required by: dlang/dmd#4848