fix Issue 15212 - BigInt should implement opCast!long and opCast!int #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberShadow
force-pushed
the
pull-20151017-003315
branch
from
efd2aef
to
c950e3d
Compare
| } | ||
|
|
||
| /// | ||
| unittest |
There was a problem hiding this comment.
This unit test will become the example for Never mind.to!ulong, but it doesn't have a call to to!ulong, just calls for int and ubyte.
There was a problem hiding this comment.
Yeah, the "why the heck not ALL integer types?" thought came after I filed the issue :)
|
✅ |
CyberShadow
force-pushed
the
pull-20151017-003315
branch
2 times, most recently
from
68ab375
to
fb964ef
Compare
CyberShadow
force-pushed
the
pull-20151017-003315
branch
from
fb964ef
to
9bb4da2
Compare
|
I don't see anybody objecting to this, so I'm going to press the button. |
|
Auto-merge toggled on |
Hackerpilot
added a commit
that referenced
this pull request
Oct 18, 2015
fix Issue 15212 - BigInt should implement opCast!long and opCast!int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15212