Fix issue 10777 - multiSort returns SortedRange #4061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| import std.algorithm.sorting: MultiPred; | ||
|
|
||
| static if( is( pred == MultiPred!P, P... ) ) | ||
| auto shrinkPred( uint n )() { |
There was a problem hiding this comment.
Think it would be nicer to have this as a freestanding UFCS function. Then you can also put it next to multiSort in std/algorithm/sorting.d.
You should be able to match shrinkPred(less...)(SortedRange!(MultiPred!less) sr).
|
Given that many SortedRange functions could be implemented more efficiently using a dedicated MultiSortedRange, we should see SortedRange!(MultiPred!less) as an intermediate solution and not make MultiPred available outside of the package. |
|
Closed in favor of #4235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiSort!( preds... ) returns SortedRange!( MultiPred!( preds ) ).
MultiPred!( preds... ) combines multiple predicates.
A proposed shrink function allows predicate reduction (a range sorted to preds[1..N] is also sorted to preds[1..(N-1)]).
https://issues.dlang.org/show_bug.cgi?id=10777