Fix issue 15807 #4091
Merged
Fix issue 15807 #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LGTM. Pretty amazing this hasn't been caught before. Tons of unit tests in |
|
There are a lot of Array!bool unit tests, but none of these verified the elements above index 32. It took me a few debugging hours, till I found that the problem was not in my code, but in phobos >:(. |
|
This is obvious enough, it doesn't need a second review. |
|
Auto-merge toggled on |
tramker
pushed a commit
to tramker/phobos
that referenced
this pull request
Sep 17, 2016
Fix issue 15807 Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.