std.traits: Add SetFunctionAttributes. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not clear whether the accepted linkage types should be restricted at all; currently, the set of acceptable names is strictly specified in the grammar, but it is conceivable that other compiler implementations provide additional types, e.g. extern(Java), which SetFunctionAttributes could work with as well without any required changes. However, without the restriction, mistyped arguments would potentially give users a confusing error message in string mixin code…
They were hardly useful and deemed potentially confusing, because not specifying them did not mean that no change should occur, which would arguably be the expected behavior.
|
Rebased and incorporated a few suggestions made in #D (thanks, everyone!). Is there anything holding this back? I understand that the implementation is not exactly beautiful, but I believe there is no better way given the current D grammar. |
jmdavis
added a commit
that referenced
this pull request
May 28, 2012
std.traits: Add SetFunctionAttributes.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, function/delegate types are quite hard to handle in D. For example, there is no easy way to add or remove attributes from functions in generic code (in situations like shown in the examples). Additionally, attributes can currently only specified in some declarations, but e.g.
cast(extern(C) void function())does not compile.The added template provides an easy solution for the former problem. I have been using it in various projects to implement things like
assumeNothrow(someDg),ExternC, etc. While something likeassumePure(or adding attributes in general) should be included in Phobos as well (likeassumeUnique), I think this is a solid start in any case.