Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.net.curl: Implement seeking in basic HTTP requests #860

Merged
merged 2 commits into from Oct 19, 2012

Conversation

CyberShadow
Copy link
Member

This enables reposting the data after a redirect, for example.

This enables reposting the data after a redirect, for example.
@andralex
Copy link
Member

Any documentation needs?

@braddr
Copy link
Member

braddr commented Oct 14, 2012

also.. unittests.

@CyberShadow
Copy link
Member Author

Any documentation needs?

It's strictly an implementation improvement (which I would expect to work without it being specified in the documentation).

also.. unittests.

For unittests, an appropriately-configured web server is needed. However, I've asked Jonas to publish the source code to his test service, so we could submit patches to allow new unittests. The source has been made available after I submitted this pull request, so I'll add an unit test now.

@CyberShadow
Copy link
Member Author

Done. Requires jcd/d-lang-testservice#1 when PHOBOS_TEST_ALLOW_NET is set in the environment.

@CyberShadow
Copy link
Member Author

The change has been pushed to the test server, the network unittests pass, so this should be good to merge now.

@alexrp
Copy link
Member

alexrp commented Oct 19, 2012

LGTM, but let's wait for the auto tester to go through it.

@alexrp
Copy link
Member

alexrp commented Oct 19, 2012

Seems to pass, so merging.

alexrp pushed a commit that referenced this pull request Oct 19, 2012
std.net.curl: Implement seeking in basic HTTP requests
@alexrp alexrp merged commit 5e9b90f into dlang:master Oct 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants