Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig.2 in your paper is misleading #2

Closed
wzm2256 opened this issue Dec 3, 2021 · 2 comments
Closed

Fig.2 in your paper is misleading #2

wzm2256 opened this issue Dec 3, 2021 · 2 comments

Comments

@wzm2256
Copy link

wzm2256 commented Dec 3, 2021

Apparently:

  1. 1D OT is not equivalent to 1D MMD.
  2. 1D MMD may fail, but 1D OT can surely align these two distributions without difficulty.

Although these flaws have no influence on your algorithm, it weakens your argument: why on earth do we need CMD?.
Therefore if I were the reviewer I would not suggest publication without modification of this part of the paper.

Nevertheless you could suggest OT is hard to compute or whatever in this case.

Anyway, Fig.2 is misleading and may confuse a large number of readers.

@D1noFuzi
Copy link
Owner

D1noFuzi commented Dec 3, 2021

Hi @wzm2256,
I think you have misread big parts of section 3.2. We do not claim that Maximum Mean Discrepancy (MMD) based approaches are equivalent to Gaussian reduced Optimal Transport (OT) in our paper, but rather that Moment Matching (MM!) with ONLY first and second order is in the 1D case. Just observe, that MM with only first and second order moments reduces to matching mean and variance and that Gaussian OT is defined by the mean and covariance matrix, which reduces to the variance in 1D.
Regarding your second claim, you are absolutely right. OT can surely align the distributions. However, we are not looking at the general form of OT, but only its Gaussian approximation due to the efficient computation (clearly stated at the end of section 3.2) and as a toy example in Fig. 2. Of course in 1D OT would be efficiently computable (since it can be reduced to CDFs under certain assumptions).

I think if you carefully read the paper, Fig. 2 is not misleading, but rather helpful to readers.

@D1noFuzi D1noFuzi closed this as completed Dec 3, 2021
@wzm2256
Copy link
Author

wzm2256 commented Dec 3, 2021

OK, I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants