[CLOSED] Initial release of hamilton

[HamiltonRepoMigrationBot]

Issue by skrawcz
Tuesday May 26, 2020 at 22:52 GMT
Originally opened as stitchfix/hamilton#1

---

This creates a package to be released.

I believe I have ported things over correctly.

The pip installable will be sf-hamilton due to naming conflict in pypi.

I have tested this locally with demandpy, and unit tests pass. Once we push a version here, I'll then be able to properly create a branch and have it go through all the tests.

---

skrawcz included the following code: https://github.com/stitchfix/hamilton/pull/1/commits

[HamiltonRepoMigrationBot]

Comment by elijahbenizzy
Wednesday May 27, 2020 at 14:14 GMT

---

Looks good. A thought: we should probably include hamiltime here as well, or in a different repo. Its more closely coupled to the internals of hamilton than demandpy. I think we should do this by including it as a plugin, E.G. an optional feature (installable target) that can be used with hamilton but is not required.

I think we should do this with the initial release, because:
(1) Many code modifications to hamiltime require modifications to hamilton as well
(2) This change clarifies ownership for hamilton/demandpy. We own hamiltime, and should thus have it in our own repo.

Happy to do it as a plugin structure as its really extra functionality on top of hamilton.

[HamiltonRepoMigrationBot]

Comment by skrawcz
Wednesday May 27, 2020 at 16:06 GMT

---

@elijahbenizzy sounds good. but 🤔 do we want commit history for hamiltime? If so I'll need to redo everything I think (perhaps I can google it...)