Fail tests on flake8 failure #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohithg
force-pushed
the
mohithg/fail-tests
branch
from
624a03f
to
9c2d725
Compare
mohithg
force-pushed
the
mohithg/fail-tests
branch
from
9c2d725
to
83b1d29
Compare
mohithg
force-pushed
the
mohithg/fail-tests
branch
from
83b1d29
to
a2e25f8
Compare
mohithg
force-pushed
the
mohithg/fail-tests
branch
17 times, most recently
from
cde3af2
to
e056b6e
Compare
mohithg
force-pushed
the
mohithg/fail-tests
branch
from
e056b6e
to
ee5e5dc
Compare
|
Why only if greater than 10 BTW? |
|
@guysmoilov just some number because you asked in the ticket to have a certain range, so I thought 10 would be a good start. Its the sum by the way. So if the total weight of issues is 10 then it will fail. Should I reduce it to 5 ? |
|
I guess I don't understand how flake8 works, I assumed we can set a "maximum allowed severity level" |
|
Then we can do selective error codes like you did for other flake8 test you are already running |
|
But I have slight preference over testing everything, and not just selected ones. Code is more hygiene that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For syntax errors we anyways fail the test, for the other errors we show them as warnings, but if the total count of these exceeds 10 then we throw an error asking user to fix those lint errors