Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ELIST compatibility and functionality #173

Open
rscs opened this issue Sep 23, 2020 · 0 comments · May be fixed by #206
Open

Check ELIST compatibility and functionality #173

rscs opened this issue Sep 23, 2020 · 0 comments · May be fixed by #206

Comments

@rscs
Copy link
Contributor

rscs commented Sep 23, 2020

From @KoraggKnightWolf in #bahamut: [16:54:06] <Koragg> I noticed in RPL_ISUPPORT that the ELIST tokens are in lowercase, though normally they are in uppercase, what was the reason to make the tokens themselves lowercase?

I don't think the case matters since the RFC (https://tools.ietf.org/html/draft-hardy-irc-isupport-00#page-11) says, "The following extensions, which a client MUST treat as being case insensitive are defined."

However, I will argue that we claim to support CMNTU when really we only support C and T. We sorta support U, M, and N as well, but not in the tokenized way required by the RFC.

So we should either fix ELIST to only include the tokens we support officially per the RFC, or add support for the tokens as defined in the RFC.

@eaescob eaescob added this to To do in Bahamut v2.2.x Feb 7, 2022
@eaescob eaescob removed this from To do in Bahamut v2.2.x Apr 6, 2022
@eaescob eaescob linked a pull request Apr 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Bahamut v2.2.2
Awaiting triage
Development

Successfully merging a pull request may close this issue.

1 participant