Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wstrncat-size warnings #226

Open
ryandesign opened this issue Jul 6, 2023 · 0 comments
Open

-Wstrncat-size warnings #226

ryandesign opened this issue Jul 6, 2023 · 0 comments

Comments

@ryandesign
Copy link
Contributor

This warning appears when compiling with a modern Clang compiler:

send.c:1442:32: warning: the value of the size argument in 'strncat' is too large, might lead to a buffer overflow [-Wstrncat-size]
        strncat(nbuf, pattern, sizeof(nbuf) - strlen(nbuf));
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
send.c:1442:32: note: change the argument to be the free space in the destination buffer minus the terminating null byte
        strncat(nbuf, pattern, sizeof(nbuf) - strlen(nbuf));
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                               sizeof(nbuf) - strlen(nbuf) - 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant