Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esac sup data #245

Merged
merged 44 commits into from
Sep 4, 2020
Merged

Esac sup data #245

merged 44 commits into from
Sep 4, 2020

Conversation

bryantaustin13
Copy link
Contributor

Please review for additional ESAC Supplemental Data requirement. NOTE: I have not coded a dstu3 version of this. Many times JP has me do so to keep them in sync. If you want that done, I can.

rob-reynolds and others added 30 commits May 13, 2020 21:21
Fixed bug in topic argument
57c1b58
Create a container for the gic sandbox
79fccff
Fixed indentation on .yml
f2c1198
Update the patient parameter to subject to match the spec
da3163a
Made topic optional
d7ec0a7
Fixed bug with Measure reference instead of MeasureReport reference
17a0837
Fixed various spec conformance issues.
b4bc76f
Added organization
0356222
Added note
c18328b
Updated evaluation to use existing evaluation
c891149
Fixed divide by zero error
386e2ad
No idea how the prior commit got that way. That was not the intent.
c154241 
Fixed.
Added DetectedIssue
c7bbefd
Added patient to DetectedIssue
8b7d68c
WIP outstanding changes. need to double check.
4454d91
@brynrhodes
Merge pull request #227 from DBCG/develop
a3166f0 
0.3.0 Release
pre-new gic branch
381bd09
Merge remote-tracking branch 'origin/develop' into davinci_gic
71ec59f
Merge remote-tracking branch 'origin/master' into davinci_gic
6d52ac3
Update to latest GIC implementation
90ae165
Merge remote-tracking branch 'origin/develop' into davinci_gic
e30d729
Update to remove var keyword
3f7cb1e
Protect against empty Org and historical measures
820cefa
Just a comment
aa86bce
additional parameter validation to meet spec
20ac4c9
status functionality in place. Refactor for cleanup needed
32f2fec
status more complete. Added Parameters ID similar to the example.
f297613
status added to produce all, closed-gap, and open-gap reports
7e37dae
Added missing elements to composition and gap report;
e76a72a
Created new EvaluatedResource inside MeasureReport.
af4502a
JPercival and others added 2 commits September 3, 2020 12:00
@JPercival
Recreate work in Dstu3
b15cfd5
@brynrhodes
Fixed logic library returning false if no type is specified (now uses…
926dbd1 
… whether or not there is CQL or ELM content if no type is specified)

Fixed an index out of range exception when no primary library could be identified
brynrhodes
brynrhodes approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, builds locally, tests pass, works with EXM124. Fixed a couple minor issues, and there is some weirdness with the evaluated resources going on, but that's a separate issue, I won't hold up approval of this PR for it.

@brynrhodes brynrhodes merged commit 138ec68 into develop Sep 4, 2020
@brynrhodes brynrhodes deleted the ESAC_Sup_Data branch September 4, 2020 02:21
@renovate renovate bot mentioned this pull request Nov 14, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynrhodes brynrhodes brynrhodes approved these changes

@sliver007 sliver007 Awaiting requested review from sliver007

@JPercival JPercival Awaiting requested review from JPercival

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryantaustin13 @brynrhodes @JPercival