Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval bug fixes #267

Merged
merged 8 commits into from
Jan 5, 2021
Merged

Eval bug fixes #267

merged 8 commits into from
Jan 5, 2021

Conversation

seanmcilvenna
Copy link
Contributor

Fixing issue where sdeListItem.get(0) is returning an ArrayList instead of the expected Coding.
Not all sdeKey values have a - in it

brynrhodes and others added 6 commits September 30, 2020 16:58
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good as far as the computation updates, not sure about the docker changes though... are those necessary?

@JPercival JPercival changed the base branch from master to develop January 4, 2021 19:28
@JPercival
Copy link
Contributor

Yeah, looks good except the docker changes. Can we get those backed out? We support multiple delivery mechanisms for the ruler so the Dockerfile intentionally doesn't build the jar.

@seanmcilvenna
Copy link
Contributor Author

I've reverted the Dockerfile changes.

@brynrhodes brynrhodes self-requested a review January 4, 2021 19:42
@seanmcilvenna
Copy link
Contributor Author

Looks like this has been approved. Looking forward to having it merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants