Fix DD-20 Jira task. Also adds proper error handling for >1 periodSta… #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt/periodEnd arguments being passed into the $care-gaps operation.
rob-reynolds
requested changes
Jun 21, 2021
| throw new IllegalArgumentException("Only one periodEnd argument can be supplied."); | ||
|
|
||
| if (subject.size() > 1 || subject.size() <= 0) | ||
| throw new IllegalArgumentException("You must supply subject argument."); |
There was a problem hiding this comment.
Can we move all this into the careGapParamaterValidation method as they are part of validation?
| if (_subject.startsWith("Patient/")) { | ||
| resolvePatientGapBundleForMeasures(_periodStart, _periodEnd, _subject, topic, status, returnParams, measures, "return", organization); | ||
| } else if (_subject.startsWith("Group/")) { | ||
| returnParams.setId((status == null ? "all-gaps" : status) + "-" + _subject.replace("/", "_") + "-report"); |
There was a problem hiding this comment.
Not related to this work, but the new API doesn't allow a null status (1..*).
Might as well fix it while we're at it.
…x to api changes.
Master's currently throwing a runtime exception so just adding this here.
rob-reynolds
requested changes
Jun 21, 2021
| } | ||
| else if (Strings.isNullOrEmpty(practitioner)) { | ||
|
|
||
| // Setting periodStart, periodEnd, and subject to lists to check if multiple have been supplied. |
There was a problem hiding this comment.
Could we move this all in careGapsParameterValidation as well?
This all looks proximate and should be contained within the same method.
rob-reynolds
approved these changes
Jun 21, 2021
rob-reynolds
deleted the
care-gaps-dd20-fix-periodStart-periodEnd-subject-multiples
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt/periodEnd arguments being passed into the $care-gaps operation.