-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update r4 to match dstu3 for OAuth provider #296
Conversation
OAuthProvider oauthProvider = new OAuthProvider(this, systemDao, daoConfig, searchParamRegistry, validationSupport); | ||
oauthProvider.setDaoConfig(daoConfig); | ||
oauthProvider.setSystemDao(systemDao); | ||
oauthProvider.setImplementationDescription("CQF Ruler FHIR DSTU3 Server"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be "R4"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running locally, got error posting a bundle: Receiver class org.hl7.fhir.r4.hapi.rest.server.R4BundleFactory does not define or inherit an implementation of the resolved method 'abstract void addRootPropertiesToBundle(java.lang.String, ca.uhn.fhir.rest.api.BundleLinks, java.lang.Integer, org.hl7.fhir.instance.model.api.IPrimitiveType)' of interface ca.uhn.fhir.rest.api.IVersionSpecificBundleFactory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R4 starts and accepts a bundle (POST).
STU3 starts, accepts bundle and passes a basic Opioid CDS request test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested R4 locally with $care-gaps (which uses $evaluate-measure). Getting expected results from all.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Builds locally. Both STU3 and R4 run, accept bundles and pass a basic Opioid CDS request test.
No description provided.