Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config log #334

Merged
merged 10 commits into from
Sep 8, 2021
Merged

Config log #334

merged 10 commits into from
Sep 8, 2021

Conversation

mdnazmulkarim
Copy link
Contributor

Make DebugMap configurable where used in ruler

@JPercival
Copy link
Contributor

JPercival commented Aug 31, 2021

Let's call the logging property hapi.fhir.cql_logging_enabled to better align with the standards in hapi fhir:

https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/master/src/main/resources/application.yaml#L70

Note that the hapi fhir server uses a newer process for setting config that we've not yet adopted, so the way the config is done will need to change to migrate this back up to hapi. I'm not worried about that at the moment because there's quite a bit of work to do to get the cqf-ruler aligned with hapi_fhir_jpaserver_starter. My plan is to cut a release of the cqf-ruler before doing all that refactoring.

@JPercival
Copy link
Contributor

Also, OHSU is working on some logback config that'll also be necessary for the logging to actually show up.

Copy link
Contributor

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -37,4 +37,9 @@
<!-- <appender-ref ref="htmlAppender" /> -->
</root>

<logger name = "org.opencds.cqf.dstu3" level="DEBUG" additivity="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're targeting CQL engine logging specifically, so this name should probably be:
org.opencds.cqf.cql.engine.debug

@@ -37,4 +37,9 @@
<!-- <appender-ref ref="htmlAppender" /> -->
</root>

<logger name = "org.opencds.cqf.r4" level="DEBUG" additivity="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: org.opencds.cqf.cql.engine.debug

@mdnazmulkarim mdnazmulkarim marked this pull request as ready for review September 8, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants