-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config log #334
Config log #334
Conversation
Let's call the logging property Note that the hapi fhir server uses a newer process for setting config that we've not yet adopted, so the way the config is done will need to change to migrate this back up to hapi. I'm not worried about that at the moment because there's quite a bit of work to do to get the cqf-ruler aligned with hapi_fhir_jpaserver_starter. My plan is to cut a release of the cqf-ruler before doing all that refactoring. |
Also, OHSU is working on some logback config that'll also be necessary for the logging to actually show up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
dstu3/src/main/resources/logback.xml
Outdated
@@ -37,4 +37,9 @@ | |||
<!-- <appender-ref ref="htmlAppender" /> --> | |||
</root> | |||
|
|||
<logger name = "org.opencds.cqf.dstu3" level="DEBUG" additivity="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're targeting CQL engine logging specifically, so this name should probably be:
org.opencds.cqf.cql.engine.debug
r4/src/main/resources/logback.xml
Outdated
@@ -37,4 +37,9 @@ | |||
<!-- <appender-ref ref="htmlAppender" /> --> | |||
</root> | |||
|
|||
<logger name = "org.opencds.cqf.r4" level="DEBUG" additivity="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above: org.opencds.cqf.cql.engine.debug
Make DebugMap configurable where used in ruler