Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature process message provider #446

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Feature process message provider #446

merged 5 commits into from
Feb 2, 2022

Conversation

jreyno77
Copy link
Contributor

@jreyno77 jreyno77 commented Feb 2, 2022

No description provided.

JPercival
JPercival approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes. I wasn't clear in my last round of feedback. "updateOrCreate" should never be needed. That's a sign of a programming error if you don't know whether to PUT/POST a resource.

@JPercival JPercival merged commit d92072a into feature-plugins Feb 2, 2022
@JPercival JPercival deleted the feature-process-message-provider branch February 2, 2022 23:29
@JPercival JPercival mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPercival JPercival JPercival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jreyno77 @JPercival