Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual box gating #20

Open
paulmueller opened this issue Dec 27, 2023 · 0 comments
Open

Manual box gating #20

paulmueller opened this issue Dec 27, 2023 · 0 comments

Comments

@paulmueller
Copy link
Member

The current Gate class only knows box gates given by input files. It might make sense to introduce the ability to set custom gating options.

  • This requires changing the pipeline identifiers for Gating
  • Requires a list/dict of (at least) common feature names and their abbreviation in the pipeline identifiers
  • Does not require bumping the PPID generation (pipeline hash changes anyway)
  • Might want to remove the online_gates keyword argument from the PPID, since box gates are overriden anyway if they are specified in PPID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmueller