Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StudyTemplate fails at PostFreeSurfer #97

Closed
jarodroland opened this issue Aug 24, 2023 · 2 comments
Closed

StudyTemplate fails at PostFreeSurfer #97

jarodroland opened this issue Aug 24, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jarodroland
Copy link

What happened?

StudyTemplate and StudyTemplateBrain are not passed to PostFreeSurferPipeline.sh: https://github.com/DCAN-Labs/abcd-hcp-pipeline/blob/13d93a3ccd39d699844622ce6be1a65119221cd4/app/pipelines.py#L743C26-L743C26
Fails without error message when AtlasRegistrationToMNI152_ANTsIntermediateTemplate.sh tries to parse the StudyTemplate parameters: https://github.com/DCAN-Labs/DCAN-HCP/blob/92913242419d492aee733a45d454ea319fbaac35/PostFreeSurfer/scripts/AtlasRegistrationToMNI152_ANTsIntermediateTemplate.sh#L114C36-L114C36

What command did you use?

docker with --study_template parameter and a custom age relevant template.

What version of the abcd-hcp pipeline are you using?

v0.1.3

Directory Structure

No response

Relevant log output

No response

Add any additional information or context about the problem here.

Resolved by editing app/pipelines.py below at

' --useStudyTemplate={usestudytemplate}' \

...
743: ' --useStudyTemplate={usestudytemplate}' \
+++: ' --studytemplate={studytemplate}' \
+++: ' --studytemplatebrain={studytemplatebrain}' \
744: ' --printcom={printcom}'
...

@jarodroland jarodroland added the bug Something isn't working label Aug 24, 2023
@LuciMoore LuciMoore self-assigned this Oct 16, 2023
@LuciMoore
Copy link
Contributor

Hi, @jarodroland. I've updated the code under the branch postFSstudytemplate. We'll try to test this branch to be thorough within the next month, but if you get to it before us and it works please let us know!

@madisoth
Copy link
Collaborator

madisoth commented Dec 8, 2023

v0.1.4 is now out, which has the fixes from the postFSstudytemplate branch -- we believe it should resolve this issue, but if you still run into problems let us know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants