Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate school display. #32

Closed
akilism opened this issue Jan 30, 2014 · 5 comments
Closed

Fix duplicate school display. #32

akilism opened this issue Jan 30, 2014 · 5 comments

Comments

@akilism
Copy link
Contributor

akilism commented Jan 30, 2014

Clicking on a school always adds a new info box to the page.

Not sure if the best behavior is to only ever have one displayed, or only ever have one for a single school displayed? Maybe limit it to X amount at a time?

@nickmcclellan
Copy link
Contributor

Hey Akil! Sorry I haven't replied to this. I think you're right, we had intended to leave it to 2-3 schools and always allow the three most recently clicked schools to remain visible. Is that something you could tackle?

@akilism
Copy link
Contributor Author

akilism commented Feb 17, 2014

Hey Nick I'll take a look at this tonight.

@nickmcclellan
Copy link
Contributor

Hey Akil! Thanks so much for your help on this again. I jumped into the code today, cleaned some of it up, and altered your code just a bit. I created a separate school div for the point information an restructured how it displays.

When you take a look at limiting the number of schools visible on click, can you do one more thing?

Is it possible to hide the schools box until a point is clicked? Right now I have to display it on the page for the .prepend code to work and it would be great if it remained invisible until a point is clicked.

I bet I could stumble through it but I don't want to mess with your work any more than I have to. Thanks again so much!

@akilism
Copy link
Contributor Author

akilism commented Feb 23, 2014

yep sure thing

@akilism
Copy link
Contributor Author

akilism commented Feb 24, 2014

Fixed this in commit 944df28.

@akilism akilism closed this as completed Feb 24, 2014
@akilism akilism removed their assignment May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants