New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install fails #15
Comments
Thanks for the issue. I actually had that happening a while ago but could not replicate it, so I thought something went wrong with my local installation. This might require a full reupload to pip to properly fix unfortunately and unlikely I can tackle that before this week-end if not later next week. So if you really have to make wavescapes in the meantime, I know this issue does not arise on google colaboratory (basically the google docs of jupyter notebook) |
Another temporary fix might be to install Cython ( |
Sweeeet, that does fix the issue! However, just so are aware, wavescapes is currently not compatible with Python 3.10 because |
Hum interesting, thanks for noticing the incompatibility with 3.10. If madmom is hard to maintain as an out of the box feature of the library, I'll think about whether it should be made a "facultative" dependancy, meaning the "import madmom" only occurs when someone wants to do wavescapes on real audio. As I feel like the target audience of the library might be more enclined to use symbolic data rather than real audio, it would make the library a bit more easy to setup. On the flipside, people that do want wavescapes on audio would have to set it up separately on their own if such decision is made |
At the same time, people analyzing audio might have their own preferred ways of getting PCVs, so having it as an optional depency is certainly an option. Currently, the interface is missing a way of easily passing your own PCVs (unless I overlooked it) and IMHO that functionality should be added anyway... |
Just had the same issue. Maybe it would be good to include a link to this issue to the README? |
Good suggestion Fabian, I changed the README to add information about this issue. The proper way to fix it will likely require to implement an optional import of madmom (or waiting on a stable version from them), and thus uploading a brand new version on the library on pip. Considering the amazing work Johannes is currently doing, I would like to package this fix with all the improvements he made in a 1.2 release. Closing this issue for now. |
Wanted to check if the matplotlib warnings from #14 also occur in fresh environments with Python 3.9 and 3.10. Both times, upon
pip install wavescpaes
this happened (environment, here, is calledms9
).Let me know if you need me to provide further information.
The text was updated successfully, but these errors were encountered: