Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document wrapper indexing does not account for content type #17

Closed
AntonOellerer opened this issue Mar 26, 2021 · 1 comment
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@AntonOellerer
Copy link
Contributor

Due to changes in the workings of the document wrapper, accessing paragraphs or tables now does not account for the specific type anymore, but has to be specified in total offset from the start.

For example, a document which has one text paragraph followed by one table followed by one text paragraph would have to be navigated in the following way documentWrapper.getParagraph(0), documentWrapper.getTable(1), documentWrapper.getParagraph(2).
While this is of course more direct, it takes away from the power of the library in my opinion, since developers now have to keep this in their mind as they develop tests.

@AntonOellerer
Copy link
Contributor Author

@alexpartsch opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant