Skip to content

Latest commit

 

History

History
322 lines (234 loc) · 11.9 KB

docker_guidance.md

File metadata and controls

322 lines (234 loc) · 11.9 KB

Docker guidance

A container is a standard unit of software that packages up code and all its dependencies so the application runs quickly and reliably across multiple environments. Docker is a tool to build and run these containers.

More information

Docker introduction on docker.com

Terminology

Dockerfile - set of instructions for building a docker image
Image - a constructed set of layered docker instructions
Container - a running instance of an image

Multi stage builds

Dockerfiles should implement multi stage builds to allow different build stages to be targeted for specific purposes. For example, a final production image does not need all the unit test files and a unit test running image would use a different running command than the application.

Below is an example multi stage build which is intended to use the Defra Node.js base image.

ARG PARENT_VERSION=1.0.0-node12.16.0
ARG PORT=3000
ARG PORT_DEBUG=9229

# Development
FROM defradigital/node-development:${PARENT_VERSION} AS development
ARG PARENT_VERSION
ARG REGISTRY
LABEL uk.gov.defra.parent-image=defradigital/node-development:${PARENT_VERSION}
ARG PORT
ENV PORT ${PORT}
ARG PORT_DEBUG
EXPOSE ${PORT} ${PORT_DEBUG}
COPY --chown=node:node package*.json ./
RUN npm install
COPY --chown=node:node app/ ./app/
RUN npm run build
CMD [ "npm", "run", "start:watch" ]

# Production
FROM defradigital/node:${PARENT_VERSION} AS production
ARG PARENT_VERSION
ARG REGISTRY
LABEL uk.gov.defra.parent-image=defradigital/node:${PARENT_VERSION}
ARG PORT
ENV PORT ${PORT}
EXPOSE ${PORT}
COPY --from=development /home/node/app/ ./app/
COPY --from=development /home/node/package*.json ./
RUN npm ci
CMD [ "node", "app" ]

Docker Compose guidance

Use override files to reduce duplication

Additional settings can be applied to a docker compose file by using override files.

Override files can be applied by listing the files after the docker-compose command with the -f parameter, i.e.

docker-compose -f docker-compose.yaml -f docker-compose.override.yaml up

Note that the above is equivalent to running the command:

docker-compose up

as calling docker-compose without specifying any files will run docker-compose with any available docker-compose.yaml and docker-compose.override.yaml files in the executing directory.

Note however that:

docker-compose up -f docker-compose.yaml

will not apply the docker docker-compose.override.yaml file, only the file specified.

One use case is for running tests in CI - common settings can be put into the base docker-compose.yaml file, while changes to the command and containers needed in local development can be placed in override files.

The below example demonstrates changing the command and container name for testing:

docker-compose.yaml

version: '3.4'
services:
  ffc-demo-service:
    build: .
    image: ffc-demo-service
    container_name: ffc-demo-service
    environment:
      DEMO_API: http://demo-api

volumes:
  node_modules: {}

docker-compose.test.yaml

version: '3.4'
services:
  ffc-demo-service:
    command: npm run test
    container_name: ffc-demo-service-test

The tests can be run by providing the docker-compose.test.yaml file with a -f parameter:

docker-compose up -f docker-compose.yaml -f docker-compose.test.yaml

It is also recommended not to expose any ports through Docker Compose used in CI as they may conflict with other ports already in use in the build agent.

Further documentation on docker-compose can be found at https://docs.docker.com/compose/reference/overview/#specifying-multiple-compose-files.

Use projects to provide unique volumes and networks

To avoid conflicts when running different permutations of docker files, projects should be specified to segregate the volumes and networks.

This can be achieved with the -p switch when calling docker compose on the command line.

i.e. to start the service

docker-compose -p ffc-demo-service -f docker-compose.yaml up

and to run the tests

docker-compose -p ffc-demo-service-test -f docker-compose.yaml -f docker-compose.test.yaml up

Use environment variables to guarantee unique projects and containers

When running through CI, a combination of the -p switch and environment variables can be used to ensure each build and test has unique project and container names. This will prevent conflicts with other build pipelines when using tools such as a single node Jenkins.

For example using Jenkins, the following compose files can be started via:

docker-compose -p ffc-demo-service-$PR_NUMBER-$BUILD_NUMBER -f docker-compose.yaml up

and tested with

docker-compose -p ffc-demo-service-test-$PR_NUMBER-$BUILD_NUMBER -f docker-compose.yaml -f docker-compose.test.yaml up

using PR_NUMBER and BUILD_NUMBER environment variables to isolate build tasks.

docker-compose.yaml

version: '3.4'
services:
  ffc-demo-service:
    build: .
    image: ffc-demo-service
    container_name: ffc-demo-service-${PR_NUMBER}-${BUILD_NUMBER}
volumes:
  node_modules: {}

docker-compose.test.yaml

version: '3.4'
services:
  ffc-demo-service:
    command: npm run test
    container_name: ffc-demo-service-test-${PR_NUMBER}-${BUILD_NUMBER}

Composing multiple repositories for local development

For scenarios where multiple containers need to be created across multiple repositories, it might be advantageous to create a "development" repo.

The development repository would:

  • clone all necessary repositories
  • builds images from Dockerfiles in each repository by referencing Docker Compose files in those repositories
  • run containers based on those images in a single Docker network by referencing Docker Compose files in those repositories
  • run single containers for any shared dependencies across repositories such as message queues or databases

To facilitate this, each repository with a potentially shared dependency will need its Docker Compose override files to be setup in such a way that dependency containers can be isolated. This will allow those repository services to run both in isolation and as part of wider service depending on development needs.

For example, let's say we have two repositories, ServiceA and ServiceB. ServiceA communicates with ServiceB via an ActiveMQ message queue. ServiceB has a PostgreSQL database.

ServiceA's Docker Compose files could be structured as follows.

docker-compose.yaml - builds image and runs ServiceA docker-compose.override.yaml - runs Artemis ActiveMQ container docker-compose.link.yaml - runs ServiceA in a named Docker network

ServiceB's Docker Compose files could be structured as follows.

docker-compose.yaml - builds image and runs ServiceB and PostgreSQL container docker-compose.override.yaml - runs Artemis ActiveMQ container docker-compose.link.yaml - runs ServiceB in a named Docker network

ServiceA and ServiceB can be run in isolation by running the following commands in each repository.

docker-compose build docker-compose up

The development repository would contain the following.

docker-compose.yaml - runs Artemis ActiveMQ container in named Docker network

A script which would run the following commands:

if [ -z "$(docker network ls --filter name=^NETWORK_NAME$ --format={{.Name}})" ]; then
  docker network create NETWORK_NAME
fi
docker-compose up
docker-compose -f path/to/ServiceA/docker-compose.yaml -f path/to/ServiceA/docker-compose.link.yaml up --detach
docker-compose -f path/to/ServiceB/docker-compose.yaml -f path/to/ServiceB/docker-compose.link.yaml up --detach

Avoiding docker-compose.yaml in the development repository

If it is preferred to avoid the need for an additional docker-compose.yaml file in the development repository itself, an alternative approach would be to explicity declare the shared resources are not started in subsequent override files in the start up script.

For example:

if [ -z "$(docker network ls --filter name=^NETWORK_NAME$ --format={{.Name}})" ]; then
  docker network create NETWORK_NAME
fi
docker-compose up
docker-compose -f path/to/ServiceA/docker-compose.yaml -f path/to/ServiceA/docker-compose.override.yaml -f path/to/ServiceA/docker-compose.link.yaml up --detach
docker-compose -f path/to/ServiceB/docker-compose.yaml -f path/to/ServiceB/docker-compose.override.yaml -f path/to/ServiceB/docker-compose.link.yaml up --detach --scale SERVICE_NAME=0

Binding volumes to container

To aide local development, the local workspace can be bound to a Docker volume. This allows code changes to be automatically picked up within the container without the need to rebuild the image or restart the container.

To best support this, workspaces should be structured so it is simple to determine which files should be bound to Docker volumes as it would not be appropriate to bind everything. For example, it would not be beneficial to bind node_modules or a README.

Example of Docker compose file with volume binding.

volumes:
  - ./app/:/home/node/app/
  - ./test/:/home/node/test/
  - ./test-output/:/home/node/test-output/
  - ./package.json:/home/node/package.json

Changes to any of the directories listed above would automatically be picked up in the running container.

Binding also allows developers to take advantage of file watching in testing applications. Changes made to code locally will automatically be reflected in the running container supporting a TDD approach.

.dockerignore

A .dockerignore file is a way of preventing local files being copied into an image during build.

For example, if a repository contains the following files.

app/index.js
app/config.js
node_modules
index.js
README.md
LICENCE
Dockerfile

The Dockerfile in this repository includes the following layer which would copy all local files to the container.

COPY . .

When the image is built then all files in the repository are copied to the image. In this scenario, it is not ideal for performance and disk space reasons to copy the node_modules, LICENCE, Dockerfile or README.md to the image.

To prevent this a .dockerignore file should be added with the following content.

node_modules
Dockerfile
LICENCE
README.md

Container and image names using Docker Compose

If an image name or container name is not specified in a Docker Compose file, then Docker Compose will determine it's own based on the service name. This can result in duplication in the name and unpredictabilty in futher container interaction.

Set image and container name

version: '3.7'
services:
  my-service:
    image: my-service
    container_name: my-service

Preserving database volumes during test runs

In many scenarios it is beneficial to utilise Docker to run local integration tests against a containerised dependency such as a database or message broker.

These tests would typically write and delete data during test execution. In order to prevent this impacting on local development data and still avoid duplication in Docker Compose definitions, volumes should be declared separate to the database definition.

For example, if you have the following Docker Compose files

  • docker-compose.yaml - base definition used in all scenarios
  • docker-compose.override.yaml - applied when running locally only
  • docker-compose.test.yaml - applied when running tests only

Then using a Postgres image as an example each definition should contain the following.

docker-compose.yaml

version: '3.7'
services:
  my-postgres-service:
    image: postgres:11.4-alpine
    environment:
      POSTGRES_DB: my_database
      POSTGRES_PASSWORD: postgres
      POSTGRES_USERNAME: postgres      

docker-compose.override.yaml

version: '3.7'
services:
  ffc-demo-claim-postgres:
    ports:
      - "5432:5432"
    volumes:
      - postgres_data:/var/lib/postgresql/data

volumes:
  postgres_data: {}

Then volume and port bindings are only used during local development and any local tests runs will not impact development data.