-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send feedback to the user when feature not available on his license (refactoring class names, etc) #287
Comments
Does it output anything in the Console? tab "PHP Language Server" |
Nothing, just the initial output:
|
We couldn't repro the issue yet. Isn't the CPU spinning, or is it idling? |
Completely idle I'll say, but difficult to guess when everything is making a good use of it Thing is neither previewing refactor (Rename symbol) changes with Shift+Enter works, there must be something, tried disabling extensions but no luck... |
any error in Help / Toggle Developer Tools / Console? I'm still not able to repro this. |
@jakubmisek Sorry to be late at this, now I know why it doesn't work, maybe what should be done here is send some feedback to the user about this feature not being available on the PHPTools license the user is using: Saw this on the new changelog screen: |
I see @d8vjork ! You are right, but as far as I know, we should be displaying a popup :/ Let me check if we do it correctly .. |
Yep, we should be displaying the popup: @d8vjork I've sent you an email ... |
@jakubmisek Thank you! And cool that you figured the issue, I guess that "Show me more" button will direct to the website to check this pricing plans differences so users can see what's offered free and not |
We're opening What's new page with more information, an option to get free Trial, and the purchase link :-) |
Is it me or this was working but not anymore?
Got to rename multiple variables but nothing happens, tried with classes and same behaviour...
Currently using latest pre-release v1.30.12518
The text was updated successfully, but these errors were encountered: