Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send feedback to the user when feature not available on his license (refactoring class names, etc) #287

Closed
d8vjork opened this issue Feb 16, 2023 · 10 comments

Comments

@d8vjork
Copy link

d8vjork commented Feb 16, 2023

Is it me or this was working but not anymore?

Got to rename multiple variables but nothing happens, tried with classes and same behaviour...

Currently using latest pre-release v1.30.12518

@jakubmisek
Copy link
Member

Does it output anything in the Console? tab "PHP Language Server"

@d8vjork
Copy link
Author

d8vjork commented Feb 16, 2023

Does it output anything in the Console? tab "PHP Language Server"

Nothing, just the initial output:

PHP Tools server started.
    PID: 56193
    Processing files: *.php; *.phtml

@jakubmisek
Copy link
Member

We couldn't repro the issue yet.

Isn't the CPU spinning, or is it idling?

@d8vjork
Copy link
Author

d8vjork commented Feb 21, 2023

We couldn't repro the issue yet.

Isn't the CPU spinning, or is it idling?

Completely idle I'll say, but difficult to guess when everything is making a good use of it

Thing is neither previewing refactor (Rename symbol) changes with Shift+Enter works, there must be something, tried disabling extensions but no luck...

@jakubmisek
Copy link
Member

any error in Help / Toggle Developer Tools / Console?

I'm still not able to repro this.

@d8vjork
Copy link
Author

d8vjork commented Mar 10, 2023

@jakubmisek Sorry to be late at this, now I know why it doesn't work, maybe what should be done here is send some feedback to the user about this feature not being available on the PHPTools license the user is using:

Saw this on the new changelog screen:

image

@d8vjork d8vjork changed the title Rename symbols not working across variables, class names, etc Send feedback to the user when feature not available on his license (refactoring class names, etc) Mar 10, 2023
@jakubmisek
Copy link
Member

I see @d8vjork ! You are right, but as far as I know, we should be displaying a popup :/

Let me check if we do it correctly ..

@jakubmisek
Copy link
Member

Yep, we should be displaying the popup:
vsc-rename-unlicensed

@d8vjork I've sent you an email ...

@d8vjork
Copy link
Author

d8vjork commented Mar 13, 2023

@jakubmisek Thank you!

And cool that you figured the issue, I guess that "Show me more" button will direct to the website to check this pricing plans differences so users can see what's offered free and not

@jakubmisek
Copy link
Member

I guess that "Show me more" button will direct to the website to check this pricing plans differences so users can see what's offered free and not

We're opening What's new page with more information, an option to get free Trial, and the purchase link :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants