Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class methods named "define" shows inconsistent warning #340

Closed
Tanguy-Magnaudet opened this issue Jun 10, 2023 · 2 comments
Closed

class methods named "define" shows inconsistent warning #340

Tanguy-Magnaudet opened this issue Jun 10, 2023 · 2 comments
Assignees
@jakubmisek
Labels
bug Something isn't working
Projects
Analysis & Completion

Comments

@Tanguy-Magnaudet
Copy link

Hello,

If a class has a method named "define" taking 3 arguments, it shows this warning, even if it's not related to the PHP define() built in function :

Defining 'case-insensitive constants' is deprecated since PHP 7.3

CleanShot 2023-06-10 at 20 00 29

The extension should not show a warning in this situation.
@jakubmisek jakubmisek self-assigned this Jun 10, 2023
@jakubmisek jakubmisek added the bug Something isn't working label Jun 10, 2023
@jakubmisek jakubmisek added this to To do in Analysis & Completion via automation Jun 10, 2023
@jakubmisek
Copy link
Member

Thank you @Tanguy-Magnaudet for reporting that. Will be fixed!

@jakubmisek
Copy link
Member

The pre-release 1.34.13249 fixes that, thank you!

Analysis & Completion automation moved this from To do to Done Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubmisek jakubmisek

Labels
bug Something isn't working
Projects
Analysis & Completion
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubmisek @Tanguy-Magnaudet