Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom id from further condition textareas so that labels match #1015

Merged

Conversation

stevehook
Copy link
Collaborator

Context

The custom id causes a mismatch between the label (that we can't specify a custom
id for) and the textarea itself.

Changes proposed in this pull request

No visible change, removing the id generates the following kind of HTML:

<div class="govuk-form-group">
  <label for="make-an-offer-further-conditions0-field" class="govuk-label govuk-label--s">First condition</label>
  <textarea id="make-an-offer-further-conditions0-field" class="govuk-textarea" rows="3" name="make_an_offer[further_conditions0]"></textarea>
</div>

Guidance to review

The id value only seemed to be referred to in a system spec and we can use a name there instead. Any other reason why we needed the id?

Link to Trello card

https://trello.com/c/BWbCBEVj/693-dac-page-15-add-form-labels-to-provider-offer-page-conditions

Things to check

  • This code doesn't rely on migrations in the same Pull Request
  • API release notes have been updated if necessary
  • New environment variables have been added to the Azure config

This causes a mismatch between the label (that we can't specify a custom
id for) and the textarea itself.
@tvararu tvararu temporarily deployed to apply-for-te-693-add-fo-snehoz January 3, 2020 15:41 Inactive
@stevehook stevehook merged commit 07b83bf into master Jan 3, 2020
@stevehook stevehook deleted the 693-add-form-labels-to-provider-offer-page-conditions branch January 3, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants