Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content for hide/show in reporting button #1025

Merged

Conversation

C-gyorfi
Copy link
Contributor

@C-gyorfi C-gyorfi commented Jan 6, 2020

Context

The ‘Hide in reporting’ and ‘Show in reporting’ buttons are not descriptive enough for all users, particularly screen reader users, to determine their function or purpose.

Changes proposed in this pull request

This PR updates the content of ‘Hide in reporting’ and ‘Show in reporting’ and related status messages to clarify their function/purpose for screen reader users.

Before

image

image

After

image

image

Guidance to review

Visit the candidates on support console and select a candidate. Try to click on Exclude this candidate from service performance data, you should see the new content.

Link to Trello card

https://trello.com/c/LIxkhgmi/696-dac-page-27-add-context-to-show-hide-in-reporting-button-in-support-application-page

Things to check

  • This code doesn't rely on migrations in the same Pull Request
  • API release notes have been updated if necessary
  • New environment variables have been added to the Azure config

@C-gyorfi C-gyorfi requested a review from tvararu January 6, 2020 12:05
@tvararu tvararu temporarily deployed to apply-for-te-696-dac-pa-zpyftt January 6, 2020 12:06 Inactive
@C-gyorfi C-gyorfi merged commit a6416ef into master Jan 6, 2020
@C-gyorfi C-gyorfi deleted the 696-dac-page-27-add-context-to-show-hide-in-reporting branch January 6, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants