Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reapply Gemfile.lock updates with correct rack version #2132

Merged
merged 1 commit into from May 22, 2020
Merged

reapply Gemfile.lock updates with correct rack version #2132

merged 1 commit into from May 22, 2020

Conversation

vigneshmsft
Copy link
Contributor

PR 2127 has applied a wrong verion of rack because of dependency on
rack-ouaut2.
Set correct version for rack and reapply other changes in the above PR.

Context

#2127 was reverted as it broke the application.

Changes proposed in this pull request

Reapply changes in 2127 and set correct rack version

Guidance to review

Link to Trello card

Things to check

  • This code doesn't rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • API release notes have been updated if necessary
  • New environment variables have been added to the Azure config

reapply Gemfile.lock updates with correct rack version
2fd7c14 
PR 2127 has applied a wrong verion of rack because of dependency on
rack-ouaut2.
Set correct version for rack and reapply other changes in the above PR.
@tvararu tvararu temporarily deployed to apply-for-te-update-rac-pnlkgp May 22, 2020 13:18 Inactive
tvararu
tvararu approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@tvararu tvararu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review app works 👍

@vigneshmsft vigneshmsft added dependencies Pull requests that update a dependency file Ruby Pull requests that update Ruby code and removed Ruby Pull requests that update Ruby code labels May 22, 2020
@vigneshmsft vigneshmsft merged commit 7217189 into master May 22, 2020
@vigneshmsft vigneshmsft deleted the update-rack-correct-verison branch May 22, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvararu tvararu tvararu approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vigneshmsft @tvararu