[1259] Expose provider in courses #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heidar
force-pushed
the
1217-expose-provider-in-courses
branch
from
c44454e
to
00e283d
Compare
|
Let's not merge this until I've updated the vacancies controller on the frontend to explicitly request site statuses and sites from the backend, as this changes them to no longer be included by default. |
defong
approved these changes
Apr 5, 2019
heidar
changed the title
added 3 commits
April 5, 2019 10:58
Also test that it can render providers.
heidar
force-pushed
the
1217-expose-provider-in-courses
branch
from
00e283d
to
992865a
Compare
heidar
pushed a commit
to DFE-Digital/publish-teacher-training-2022
that referenced
this pull request
Apr 5, 2019
This is needed to match up with changes on the backend: DFE-Digital/publish-teacher-training#245 These changes cause the API request to ask for site statuses and sites to be included in the course.
heidar
pushed a commit
to DFE-Digital/publish-teacher-training-2022
that referenced
this pull request
Apr 5, 2019
This is needed to match up with changes on the backend: DFE-Digital/publish-teacher-training#245 These changes cause the API request to ask for site statuses and sites to be included in the course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to expose
providerandaccrediting_provideron the course endpoint.Changes proposed in this pull request
Rather than hard coding the course endpoint to return
site_statusesandsites, we now rely on theincludeparameter.Added a bunch of tests for the serializer to make sure we can render out everything we need.
Guidance to review
I originally included a request spec in this that brings in provider and accredited_provider, but decided it was overkill in the end.