Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3725 rollover settings #1520

Closed
wants to merge 2 commits into from
Closed

3725 rollover settings #1520

wants to merge 2 commits into from

Conversation

defong
Copy link
Contributor

@defong defong commented Aug 13, 2020

Context

Changes proposed in this pull request

Guidance to review

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@defong
Copy link
Contributor Author

defong commented Aug 13, 2020

@defong
Copy link
Contributor Author

defong commented Aug 20, 2020

Spiked
close DFE-Digital/find-teacher-training#386
close #1304
close #1520

@defong defong closed this Aug 20, 2020
@@ -6,3 +6,5 @@ bg_jobs:
cron: "0 0 * * *" # daily at midnight
class: "SaveStatisticJob"
queue: save_statistic
current_recruitment_cycle_year: 2021
allocation_cycle_year: 2021
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is conflicting....
allocation_cycle_year should be (current_recruitment_cycle_year -1)

This is so that the previous values can be shown

@vigneshmsft vigneshmsft deleted the 3725-rollover-settings branch November 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant