0209 update settings to complete rollover #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defong
force-pushed
the
0209-update-settings-to-complete-rollover
branch
from
9ea6b94
to
72adf30
Compare
Need to lock down none moveable settings
Retained hardcore value for recruitment cycle year
This is so it relies on settings current recruitment cycle year (rollovered) insteads.
This is to constrained recruitment year to the rollovered cycle
The tests needs to be within the current recruitment year (rollovered).
This is so that the tests operate beyond the realm or current recruitment cycle.
defong
force-pushed
the
0209-update-settings-to-complete-rollover
branch
from
72adf30
to
49f570d
Compare
gpeng
approved these changes
Oct 5, 2020
misaka
reviewed
Oct 5, 2020
| # Note: the concept of recruitment cycle here is ethereal. | ||
| # it is tied to a recruitment cycle that is associated to | ||
| # Settings.allocation_cycle_year | ||
| allocation_recruitment_cycle |
There was a problem hiding this comment.
In the settings we call this allocation cycle. That makes more sense than allocation recruitment cycle, in my mind at least, should we use that or is the longer version correct?
misaka
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rollover
Changes proposed in this pull request
Rollovered
Guidance to review
Best to view by commits
Config change cause some broken tests due to hardcoring.
As well as the ethereal nature of recruitment cycle vs allocation year over allocation
Checklist