Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date vs dateTime in CSIP7, CSIP8 #645

Closed
koit opened this issue Dec 14, 2020 · 3 comments · Fixed by #687
Closed

Date vs dateTime in CSIP7, CSIP8 #645

koit opened this issue Dec 14, 2020 · 3 comments · Fixed by #687
Assignees

Comments

@koit
Copy link
Contributor

koit commented Dec 14, 2020

CSIP7 Package creation date mets/metsHdr/@CREATEDATE description reads:

"mets/metsHdr/@CREATEDATE records the date the package was created."

This is confusing, as the attribute is defined in mets.xsd as xsd:dateTime, meaning it only takes values that include time, e.g. 2020-12-14T20:52:00. It would be good to be explicit about the handling of the time part, e.g. with wording similar to mets.xsd:
"Records the date/time the METS document was created."

Or, if we don't want the exact time then say something like:
"… records the date the package was created (time MUST be set to 0:00, e.g. 2020-12-14T00:00:00)."

The same applies to CSIP8.

@karinbredenberg karinbredenberg removed their assignment Jan 11, 2021
@karinbredenberg
Copy link
Contributor

A text enhancement that will need to wait for the next release which is planned earliest fall 2021.

@karinbredenberg
Copy link
Contributor

In addition to CSIP7 and CSIP8 there are use of data type datetimes also in CSIP19, CSIP28, CSIP14, CSIP55, CSIP70. There are different ways to add this information:

  1. In the name of each change so it states datetime instead of date.
  2. Add an explanatory text in the beginning of the specification about datetimes being used and not change any names of the elements and there add how to enter it when its only the date that are recorded.
  3. Add the explanation to all the requirements that have dates and keep the elements name.

@carlwilson we need to discuss the best solution here.

@carlwilson carlwilson modified the milestone: CSIP Version 2.1 Oct 5, 2021
@carlwilson carlwilson linked a pull request Oct 13, 2021 that will close this issue
@karinbredenberg
Copy link
Contributor

Closed with PR #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants