Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Items w Children Not Functional on iPad / Android #4

Closed
datyger opened this issue Jul 1, 2013 · 4 comments
Closed

Menu Items w Children Not Functional on iPad / Android #4

datyger opened this issue Jul 1, 2013 · 4 comments

Comments

@datyger
Copy link

datyger commented Jul 1, 2013

I have installed the repo's code unaltered and also doctored a version to fit our organization and only parent pages without children are clickable / reachable on iPad and Android.

On Android, the menu opens and closes instantly -- but if you tap and hold for 1/2 second the submenu will expand and stay open but then any subsequent taps / holds merely close the submenu back up.

On iPad, the menu opens and closes properly but clicking on any children options simply closes the menu back up.

I see a lot of banter about this here: twbs/bootstrap#4550 and I tried variations on the many workarounds and fixes mentioned there... to no avail.

I also see this statement at Twitter Bootstrap site:
"To keep URLs intact, use the data-target attribute instead of href="#"." - should we try and adapt the navigation.vm to use this?

Anyone else seeing this? Is there something I am missing? Any ideas?

Thanks for any input.

@datyger
Copy link
Author

datyger commented Jul 5, 2013

I have found an answer to this problem. There are a lot of threads / issues pointing at the bootstrap dropdown.js lines 797-800 as needing altered >> mostly all those ended up misleading and not fixing the issues cited w/ 2.3.2 BS and iPad / Android menus not working...

However - this post really helped me get the menus working on iPad and Android:
twbs/bootstrap#7968

racl101 explains that a CSS change of the .dropdown-backdrop div from position: fixed; >> position: static; can make all the difference. And, indeed it did - all my menus are working now on iPad / Android / large screen browsers.
Thank you, again for this nice head start and manifestation of BS + Liferay in a responsive design. I look forward to sharing a lot of the things I have been doing to adapt this to our university portal.

@pilarargudo
Copy link
Member

Hi Daniel,

Thanks for sharing the fix! Soon we will apply to our site too.
We would love to see this customized theme in your university portal.

@datyger
Copy link
Author

datyger commented Jul 11, 2013

Pilar,

I could show you a demo of where I am so far. I'd love to meet someone there who worked on this project so I can thank them for the head start. I am also eager to share things we have done, if any of it is valuable. I am new to sharing via GIT, but I will take the time to do what is necessary to share back possibly valuable changes to others.

I did some architectural changes to the .vms to provide more flexibility and control, allow us to edge in some external applications into the banner, and to allow for an optimized banner height even when the collapsed nav button is exposed.

Let me know if we could meet up for a webinar to say hello.

daniel

@pilarargudo
Copy link
Member

Hi Daniel,

for now we do not plan any webinar.
From DISID we appreciate your contribution to the project and your comments :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants