Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4: lv2lint fails on LV2 plugins #17

Closed
dvzrv opened this issue Jan 15, 2021 · 4 comments
Closed

1.4: lv2lint fails on LV2 plugins #17

dvzrv opened this issue Jan 15, 2021 · 4 comments

Comments

@dvzrv
Copy link

dvzrv commented Jan 15, 2021

Hi! When packaging 1.4 for Arch Linux I ran lv2lint against all LV2 plugins.

This fails on:

lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/3BandEQ>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/3BandSplitter>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers

lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers

lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/Kars>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/MVerb>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
error: failed to open file /build/dpf-plugins/src/dpf-plugins-1.4/bin/MaBitCrush.lv2/manifest.ttl (No such file or directory)
lilv_world_load_file(): error: Error loading file `file:///build/dpf-plugins/src/dpf-plugins-1.4/bin/MaBitCrush.lv2/manifest.ttl'
lilv_world_load_bundle(): error: Error reading file:///build/dpf-plugins/src/dpf-plugins-1.4/bin/MaBitCrush.lv2/manifest.ttl

lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/MaFreeverb>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Hard RT Capable
              not advertized as real-time safe
              seeAlso: <http://lv2plug.in/ns/lv2core#hardRTCapable>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/MaGigaverb>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Hard RT Capable
              not advertized as real-time safe
              seeAlso: <http://lv2plug.in/ns/lv2core#hardRTCapable>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/MaPitchshift>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Hard RT Capable
              not advertized as real-time safe
              seeAlso: <http://lv2plug.in/ns/lv2core#hardRTCapable>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/Nekobi>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/PingPongPan>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/ProM>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Hard RT Capable
              not advertized as real-time safe
              seeAlso: <http://lv2plug.in/ns/lv2core#hardRTCapable>
  <http://distrho.sf.net/plugins/ProM#UI>
    [FAIL]  UI Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [WARN]  UI Instance Access
              usage of instance-access is highly discouraged
              seeAlso: <http://lv2plug.in/ns/ext/instance-access>
    [WARN]  UI Data Access
              usage of data-access is highly discouraged
              seeAlso: <http://lv2plug.in/ns/ext/data-access>
    [WARN]  UI Mixed DSP/UI
              mixing DSP and UI code in same binary is discouraged
              seeAlso: <http://lv2plug.in/ns/extensions/ui#>


lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers

lv2lint 0.10.0
Copyright (c) 2016-2021 Hanspeter Portner (dev@open-music-kontrollers.ch)
Released under Artistic License 2.0 by Open Music Kontrollers
Host does not provide nominalBlockLength or maxBlockLength options
<http://distrho.sf.net/plugins/glBars>
    [FAIL]  Plugin Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [FAIL]  Plugin License
              doap:license not a URI
              seeAlso: <http://usefulinc.com/ns/doap#license>
    [WARN]  Plugin Author Email
              foaf:mbox not found
              seeAlso: <http://lv2plug.in/ns/lv2core#project>
    [WARN]  Plugin Hard RT Capable
              not advertized as real-time safe
              seeAlso: <http://lv2plug.in/ns/lv2core#hardRTCapable>
  <http://distrho.sf.net/plugins/glBars#UI>
    [FAIL]  UI Symbols
              binary exports superfluous globally visible symbols: 
                * lv2_generate_ttl
              seeAlso: <http://lv2plug.in/ns/lv2core#binary>
    [WARN]  UI Instance Access
              usage of instance-access is highly discouraged
              seeAlso: <http://lv2plug.in/ns/ext/instance-access>
    [WARN]  UI Data Access
              usage of data-access is highly discouraged
              seeAlso: <http://lv2plug.in/ns/ext/data-access>
    [WARN]  UI Mixed DSP/UI
              mixing DSP and UI code in same binary is discouraged
              seeAlso: <http://lv2plug.in/ns/extensions/ui#>

Is there anything that can be done about those failures? I remember from another report against DPF related plugins that the lv2_generate_ttl might be non-circumventable. Is that still the case?
@falkTX
Copy link
Contributor

falkTX commented Jan 15, 2021

Yes, all those are expected.

The license situation I will fix in a later release, and "lv2_generate_ttl" is now something you can whitelist in lv2lint.
Everything else is "just" a warning, and expected to be there.

@dvzrv
Copy link
Author

dvzrv commented Jan 15, 2021

Okay, I'll whitelist the symbol then and "not fail" with a reference to this ticket then for the license related topic. Would be nice to close this issue once the license topic is resolved.

Thanks! :)

@falkTX
Copy link
Contributor

falkTX commented Jan 15, 2021

Sure.

To be clear on the license situation, I simply prefer to have developers write the license name on DPF side, and then have DPF figure out the URL for such license.
But this is purely cosmetic, so not done yet as I see it as very low priority.

@falkTX
Copy link
Contributor

falkTX commented Sep 19, 2021

Now fixed, lv2lint is part of the automated testing.
Release to be made in 25 days.

@falkTX falkTX closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvzrv @falkTX