Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Like the previous issue with a special character, but this time, the album has a single quote in it, and it confuses the program #12

Closed
k-quiroz opened this issue Apr 17, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@k-quiroz
Copy link

k-quiroz commented Apr 17, 2023

Tried to download an album with a single quote ( ' ) in its name. In this case, I tried to download hololive meets DJ'TEKINA//SOMETHING remix, and it shows an error. I think it can't find the path because of the single quote.
image

@k-quiroz k-quiroz changed the title [Bug] Like the previous issue with a special character, but this time, the album has a single quote in it, and it confuses the program [BUG] Like the previous issue with a special character, but this time, the album has a single quote in it, and it confuses the program Apr 17, 2023
@DJDoubleD
Copy link
Owner

The single quote isn't the problem, that's a valid character to use in a folder name.
The problem is an unlucky and unforeseen circumstance:

The default "max file name length" is set to 36, which I'm guessing was left on the default value.
Trimming the album name to remove trailing spaces was done before truncating the album name to fit the selected max length.
It just so happens that when you trim hololive meets DJ'TEKINA//SOMETHING remix down to 36 characters, you get hololive meets DJ'TEKINA//SOMETHING => a new path string with trailing space...

I will fix this in a next release by making sure that a trimmed down path string can never return a value with a trailing space. But a simple workaround while you wait is increasing the max file name length setting. This is probably what you want anyway to get the full album title in the path.

@DJDoubleD DJDoubleD added the bug Something isn't working label Apr 17, 2023
@DJDoubleD DJDoubleD self-assigned this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants