Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

going early late - changing + and - signs #43

Closed
marass007 opened this issue Jan 8, 2023 · 5 comments
Closed

going early late - changing + and - signs #43

marass007 opened this issue Jan 8, 2023 · 5 comments
Labels
enhancement New feature or request Priority

Comments

@marass007
Copy link

Hey, maybe wil be better to change the + and - signs at train info. - when is early and + when is late.
image
image

@DKFN DKFN added the enhancement New feature or request label Jan 8, 2023
@DKFN
Copy link
Owner

DKFN commented Jan 8, 2023

Hey !
It seems to be a localisation issue, in france we show late trains with the - and early trains with the + (wich is confusing).
But, at the EDR is available in many languages I think it would be a good idea to add this in the localisation files of each languages. What do you think ?

Thanks for reporting !

@marass007
Copy link
Author

marass007 commented Jan 8, 2023

I absolutely agree.
It's question of localisation, we thought About this for CZ localisation.

For Global purposes is there question if it's better to add this in the localisation files of each languages, or just make some script which will separate localisations to two groups (+, - | -, +) based on feedback from users of each localisation.

@DKFN
Copy link
Owner

DKFN commented Jan 9, 2023

I think the localisation files would be perfect for this use.
It will not add more code, and allows for locale derivates, for example fr_FR for french rules, fr_BE for belguim, fr_SN for senegal etc and will default to english rules

@marass007
Copy link
Author

Ok

@DKFN DKFN added the Priority label Jan 9, 2023
@DKFN DKFN closed this as completed Jan 10, 2023
@Tallyrald Tallyrald added Pending Release The issue has been fixed on the developpement branch but not on online version and removed Pending Release The issue has been fixed on the developpement branch but not on online version labels Jan 10, 2023
@DKFN
Copy link
Owner

DKFN commented Jan 10, 2023

Released 0.7 thanks for the issue and the fix ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority
Projects
None yet
Development

No branches or pull requests

3 participants