Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Table access for WES/WGS #19

Open
vinjana opened this issue Nov 15, 2018 · 0 comments
Open

Metadata Table access for WES/WGS #19

vinjana opened this issue Nov 15, 2018 · 0 comments

Comments

@vinjana
Copy link
Member

vinjana commented Nov 15, 2018

In contrast to WGBS, the WES and WGS workflows currently still use the extraction of execution parameters (sample, pid, etc.) from paths.

  • Centralize all path parsing code (maybe in a service)
  • Can the service be made a ParameterAccumulator that collects the data incrementally?
  • Can the execution model be changed to first read all parameters (e.g. from the paths or the metadata table) and afterwards execute?

Furthermore,

  • accept BAM file path as input and merge into existing BAM (inkremental merging)
  • check that all read groups in the BAM are also provided in the metadata table (+ possibility to turn off this check)
  • if all fastqs are already in the BAM do (1) nothing?, (2) mark again?, (3) only QC? -- best provide all three options as configurable behaviour.

Note that path-parsing code is also in RoddyCore. E.g. de.dkfz.roddy.core.RuntimeService#extractDataSetIDFromPath
It may be a possible to start in the AQCWF, generalize into COWF and even later in the RoddyCore, as was done for the MetadataTable. Then MetadataTable and PathExtraction may become strategies (Strategy Pattern). Others may be e.g. getting data from a database (such as OTP).

@vinjana vinjana added this to Backlog in AlignmentAndQCWorkflows via automation Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant