Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Fork p4est and libsc #1018

Closed
jmark opened this issue Apr 10, 2024 · 1 comment
Closed

Proposal: Fork p4est and libsc #1018

jmark opened this issue Apr 10, 2024 · 1 comment

Comments

@jmark
Copy link
Collaborator

jmark commented Apr 10, 2024

t8code depends on p4est and libsc. They are included via the git submodule mechanism.

From time to time, we need to push fixes upstream to p4est or libsc in order to maintain compatibility with latest developments in t8code.

In order to be a bit more independent and speed up our development process, I propose to fork both libraries into the DLR-AMR github project and link t8code against these forks.

We can push our changes to libsc and p4est to these forks, test them properly and if they proven their worth can be pushed as PRs to the original repositories.

@cburstedde
Copy link
Collaborator

I understand that you may be prompted to do this. It may however be the first step of a serious divergence that might become ever harder to fix in the future. Since we guarantee that the p4est history never moves backwards, what would speak against working through PRs against the official p4est history as previously?

I can only guess that you're missing the sc_MPI_INT8 type that we have removed to work with a relatively ancient MPI standard. Would it not be sufficient to #define sc_MPI_INT8 sc_MPI_BYTE in a toplevel t8code .h file to get it all to work?

Happy to discuss further!

@holke holke closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants