Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Pass all gym Environments in this repo through the env checkers during testing #1156

Closed
1 task done
tlpss opened this issue Nov 3, 2022 · 4 comments 路 Fixed by #1327
Closed
1 task done
Labels
enhancement New feature or request

Comments

@tlpss
Copy link
Contributor

tlpss commented Nov 3, 2022

馃殌 Feature

Both the Gym repo and this repo have an env_checker but currently the environments in this repo (most of them are for testing purposes) are not checked against these checkers. This would help catch faulty implementations of changes in the gym API (e.g. the new render API).

I realise this is actually a test on 'test code' but I think it would help maintaining the tests.

Motivation

No response

Pitch

No response

Alternatives

No response

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
@tlpss tlpss added the enhancement New feature or request label Nov 3, 2022
@qgallouedec
Copy link
Collaborator

I would tend to agree with you.
Have you tested these environments by the way? Are there any bad surprises?
Your contribution is welcome :)

@ReHoss
Copy link
Contributor

ReHoss commented Nov 8, 2022

Remarks:

  • Version of gym used in sb3 is not the latest one.
  • sb3 env_checker is more restrictive than the one from gym.

@araffin
Copy link
Member

araffin commented Nov 10, 2022

Version of gym used in sb3 is not the latest one.
This would help catch faulty implementations of changes in the gym API (e.g. the new render API).

I think it would make sense to include that in #780
but not before (the gym env checker was derived from SB3 one).

@qgallouedec qgallouedec mentioned this issue Nov 10, 2022
19 tasks
@qgallouedec
Copy link
Collaborator

I think it would make sense to include that in #780

If you want to contribute, you can therefore create a PR on this branch https://github.com/carlosluis/stable-baselines3/tree/fix_tests.
I've added it to the check list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants