Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation 'wasGeneratedBy' for 'tags' incorrect. #51

Closed
onyame opened this issue Jun 16, 2021 · 2 comments
Closed

Relation 'wasGeneratedBy' for 'tags' incorrect. #51

onyame opened this issue Jun 16, 2021 · 2 comments
Assignees
Labels
bug Something isn't working model Improvements or additions to the PROV model
Milestone

Comments

@onyame
Copy link
Member

onyame commented Jun 16, 2021

In the generated PROV document, the wasGeneratedBy relation between tag_event Activity and tag Entity has wrong direction. In the model file model.py its correct.

@onyame onyame added bug Something isn't working model Improvements or additions to the PROV model labels Jun 16, 2021
@onyame onyame added this to the 0.5 milestone Jun 16, 2021
@onyame
Copy link
Member Author

onyame commented Jun 16, 2021

IMG_0372

@cdboer
Copy link
Collaborator

cdboer commented Jun 17, 2021

Good find! It was in the wrong direction in models/__init__.py

if package.tag_package is not None:
    "..."
    graph.wasGeneratedBy(tag_event.id, tag.id)
   "..."

The right direction would be the other way around.

if package.tag_package is not None:
    "..."
    graph.wasGeneratedBy(tag.id, tag_event.id)
   "..."

Im going to fix this in the next commit.

@cdboer cdboer closed this as completed in 6efc6d5 Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working model Improvements or additions to the PROV model
Projects
None yet
Development

No branches or pull requests

2 participants