Chopper should check states before triggering command switches #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sm.process(0) | ||
| self.assertEqual(sm.state, 'bar') | ||
| self.assertEqual(sm.can('foo'), True) | ||
| self.assertEqual(sm.can('init'), True) |
There was a problem hiding this comment.
Arguably, these could use self.assertTrue() and self.assertFalse() respectively. Another alternative would be self.assertIs().
I don't really have a preference one way or the other, just something to consider.
self.assertIs() would have the benefit of testing for identity with True and False; all the other asserts will succeed even if the value is only "truthy" or "falsy" (1 == True, 0 == False, etc).
There was a problem hiding this comment.
That's a good point, thanks. I used assertEqual so that you can see what it returns. It sounds like assertIs is the thing that really should be used here.
added 5 commits
September 1, 2016 14:37
StateMachine now has a method "can", which returns true if the state supplied as the argument is reachable from the current state. This is required for some of the chopper logic. Refs #84.
The chopper commands like start, stop, unlock, etc. are now only executed if the state machine allows the transition to the desired state. Refs #84.
MichaelWedel
force-pushed
the
84_chopper_command_switches
branch
from
e867238
to
0b844ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #84.
To test you could start the chopper (in the sense of setting a speed and a phase) and then issue a
deinit-command. Like before, nothing happens. If you then issuestop, it should not go directly to theinit-state as it did before.This device needs unit tests at some point.