ENH: Store and retrieve templates to/from file system #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WillStrohl @Timo-Breumelhof Since previous PR #194 was just too big for good testing, I canceled it and I'm moving some of those changes into earlier PRs (like #226 for removing hardcoded paths). I will also be creating additional future PRs for moving templates to host folder rather than desktopmodules, moving themes to host folder rather than desktopmodules, and packaging up the themes from dnncommunity.org. |
|
Ok seem logical, thank you:-) |
3 tasks
Per @WillStrohl recommendation, add try/catch to log any errors encountered during code-based upgrade.
…l_Or_Upgrade_MoveTemplates()
…te to module cache to avoid merge conflict
johnhenley
changed the title
|
@johnhenley These should be easy to remedy. :) |
done i hope :) |
|
Yep, we're good this time! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
Editing and testing Forum Templates is cumbersome because the templates are in the database. File-based templates makes creating and maintaining templates much easier.
Changes made
Templates are now retrieved from .txt files rather than database
During upgrade, templates existing in the database table
activeforums_templatesare extracted to~/DesktopModules/ActiveForums/{theme}/templates/based on the theme associated with the template's module instance. Templates not associated to a module instance are written to~/DesktopModules/ActiveForums/{theme}/templates/Template files are named using the template's "title", e.g., ForumView.txt. If multiple templates with the same name exist within the same instance of the Forums module installed on the DNN host, the template file names are made unique by appending the ModuleId and TemplateId from
activeforums_Templatesto the filename, e.g., TopicView-43-18.txt.When loading templates at runtime, they are loaded from (in high-to-low priority order):
~/DesktopModules/ActiveForums/{theme}/templates/~/DesktopModules/ActiveForums/templates/~/DesktopModules/ActiveForums/config/templates/(delivered templates)Templates can either be edited directly on the server or can still be edited using the template editor in the Forums module. The template file name is displayed in the template editor:
PR Template Checklist
Please mark which issue is solved
Closes #93